Re: 01/01: gnu: Add agg.

[Ludovic Courtès]

Tomáš Čech <address@hidden> skribis:

> On Wed, Mar 18, 2015 at 02:09:49PM +0100, Ludovic Courtès wrote:
>>Tomas Cech <address@hidden> skribis:

[...]

>>> +@@ -8,7 +8,6 @@
>>> + AC_PROG_CC
>>> + AC_PROG_CXX
>>> + AC_ISC_POSIX
>>> +-AM_C_PROTOTYPES
>>> + if test "x$U" != "x"; then
>>> +   AC_MSG_ERROR(Compiler not ANSI compliant)
>>> + fi
>>
>>It is best to avoid modifying .ac or .am files because that requires
>>adding a dependency on the autotools.]
>
> I will remember that but I'm afraid that in this case there is no
> configure in tarball anyway and has to be generated.

Oh, right, sorry for the confusion!  If that has to be generated anyway,
then fine, no problem.

>>What problem does this patch solve?  I’m confident this can be worked
>>around without modifying the .ac file, for instance by passing the right
>>ac_cv_ variable as a ‘configure’ argument.
>
>
> AM_C_PROTOTYPES has been removed from automake.
>
> https://lists.gnu.org/archive/html/automake-patches/2011-06/msg00082.html

Right, so you made the right decision.  Just mention it in the patch.

Thank you!

Ludo’.