Re: [PATCH 1/2] gnu: sdl: Allow dlopen for OpenGL.

[宋文武]

Ludovic Courtès <address@hidden> writes:

> 宋文武 <address@hidden> skribis:
>
>> Fixes a regression introduced in 666aa99.
>> Reported by Felipe López and David Thompson.
>>
>> * gnu/packages/sdl.scm (sdl)[inputs]: Add glu.
>>   [arguments]<#:configure-flags>: Replace '--disable-sdl-dlopen' with
>>   '--disable-alsa-shared --disable-pulseaudio-shared --disable-x11-shared'.
>
> [...]
>
>> --- a/gnu/packages/sdl.scm
>> +++ b/gnu/packages/sdl.scm
>> @@ -60,8 +60,11 @@
>>      (build-system gnu-build-system)
>>      (arguments
>>       '(;; Explicitly link against shared libraries instead of dlopening 
>> them.
>> -       ;; For X11, ALSA, PulseAudio, etc.
>> -       #:configure-flags '("--disable-sdl-dlopen")
>> +       ;; For X11, ALSA, and PulseAudio.
>> +       ;; OpenGL library is still dlopened at runtime.
>> +       #:configure-flags '("--disable-alsa-shared"
>> +                           "--disable-pulseaudio-shared"
>> +                           "--disable-x11-shared")
>
> So without these flags libpulse.so, libalsa.so, etc. are dlopened?
> (“disable shared” is a bit misleading in the flag names.)
Yes.
>
>>      (native-inputs `(("pkg-config" ,pkg-config)))
>>      (inputs `(("libxrandr" ,libxrandr)
>>                ("mesa" ,mesa)
>> +              ("glu" ,glu)
>
> Because of --disable-x11-shared, glu must be found at configure time,
> right?
No, without glu, SDL's configure reported with:
  checking for OpenGL (GLX) support... no

Maybe it's because the mesa update from 8.0.5 to 10.4.0?
I think many packages had adding glu to inputs due to this,
but we missed SDL :)


> Thanks,
> Ludo’.