Re: [PATCH] Add pbtranscript-tofu.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> From 39f77a513b2505d2a9658f6f9ed40f24a6b93dfd Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 18 Mar 2015 14:39:42 +0100
> Subject: [PATCH 1/2] gnu: Add python2-bx-python.
>
> * gnu/packages/bioinformatics.scm (python2-bx-python): New variable.

LGTM.

> From 42c865d2c29b7c68e81580de98997266112d6cd9 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 20 Mar 2015 14:36:38 +0100
> Subject: [PATCH 2/2] gnu: Add pbtranscript-tofu.
>
> * gnu/packages/bioinformatics.scm (pbtranscript-tofu): New variable.

[...]

> +    (version "0.4.1-c7bbd5472")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url 
> "https://github.com/PacificBiosciences/cDNA_primer.git";)
> +                    (commit "c7bbd54720df578777743d687ceaf6b4f6d4919e")))

To avoid mistakes in the future, I would do:

  (let ((commit "c7bbd5472"))
    (package
      (version (string-append "0.4.1." commit))
      (source (origin ...
                (commit commit)))
      ;; ...
      ))

Also, I think 0.4.1.c7bbd5472 is slightly nicer than 0.4.1-c7bbd5472.

Other than that LGTM.

Thanks!

Ludo’.