guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add cutadapt.


From: Ludovic Courtès
Subject: Re: [PATCH] Add cutadapt.
Date: Tue, 24 Mar 2015 22:00:19 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Ricardo Wurmus <address@hidden> skribis:

> From 18a14112b6e22248638d2b34e1c1b935e1bcd343 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 20 Mar 2015 16:17:55 +0100
> Subject: [PATCH] gnu: Add cutadapt.
>
> * gnu/packages/bioinformatics.scm (cutadapt): New variable.

[...]

> +                   (setenv "PYTHONPATH"
> +                           (string-append
> +                            (getenv "PYTHONPATH")
> +                            ":" (assoc-ref outputs "out")
> +                            "/lib/python"
> +                            ,(version-major+minor (package-version python))
> +                            "/site-packages"))

It’s best to check the Python version on the build side, using something
like ‘get-python-version’ from python-build-system.scm (so that if
someone inherits this package and changes the Python that is used it
still works.)

Other than that LGTM!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]