Re: [PATCH] Add Julia.

[Mark H Weaver]

Ricardo Wurmus <address@hidden> writes:

> Mark H Weaver writes:
>
>> Ricardo Wurmus <address@hidden> writes:
>>
>>> May I suggest adding passing the "DYNAMIC_ARCH=1" flag in openblas
>>> instead of propagating non-substitutability to Julia?  When built with
>>> "DYNAMIC_ARCH=1" the CPU type can be picked with the environment
>>> variable OPENBLAS_CORETYPE=<type>.  If I'm not mistaken this makes
>>> substitutions for openblas possible.
>>>
>>> What do you think?
>>
>> Yes, we should do this.
>
> Attached is a patch to make openblas substitutable.
>
> From 326fa66415fe8e9ed2b28a249b903f4a654b769e Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 25 Mar 2015 19:20:11 +0100
> Subject: [PATCH] gnu: openblas: build for all supported CPUs.
>
> * gnu/packages/maths.scm (openblas)[arguments]: Pass make flag
>   "DYNAMIC_ARCH=1" to build library for all CPUs, making it substitutable.

This explanation of the purpose of "DYNAMIC_ARCH=1" belongs as a comment
in the source code, rather than in the commit log.  You might also make
it clear that this enables runtime CPU detection.

The commit log should only summarize what changed, maybe something along
these lines:

* gnu/packages/maths.scm (openblas)[arguments]: Add "DYNAMIC_ARCH=1" to
  make flags.  Remove "#:substitutable? #f".

Otherwise it looks good to me.  Please push with these changes.

    Thanks!
      Mark