[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ruby-rake-compiler
From: |
Thompson, David |
Subject: |
Re: [PATCH] ruby-rake-compiler |
Date: |
Sat, 4 Jul 2015 09:55:57 -0400 |
Hey Pjotr,
On Sat, Jul 4, 2015 at 9:08 AM, Pjotr Prins <address@hidden> wrote:
> Attached a Ruby module in preparation of Nokogiri support.
I've applied this patch with a number of changes:
* Removed the use of 'snippet'. That is for making changes that
aren't specific to building for Guix, like removing a piece of
non-free source. The cucumber task file is now deleted in a phase
that runs before the 'build' phase.
* Used the 'modify-phases' syntax instead of 'alist-replace' and friends.
* Removed the rspec native input. It can be added back in when we can
actually run the test suite.
* Cleaned up synopsis/description to use more neutral language.
* Fixed license. It's actually the Expat license, which is verrrrry
similar to the X11 license.
> (I am pretty close as described in
> https://github.com/pjotrp/guix-notes/blob/master/RUBYGEMS-Nokogiri.org).
>
> Cucumber support comes later (it depends on Nokogiri itself).
Sounds like we'll have to do a similar dance that I did with rspec:
Disable test suites for all dependencies of cucumber. :(
> David: there are quite a few modules now that build gems through 'rake
> gem'. Would it be an idea to try that by default when there is no
> gemspec file?
Yes, I think that would be a good change. Want to write a patch that
does that and updates all of the relevant package recipes?
Thanks! It will be nice to have Nokogiri!
- Dave