Re: [PATCH 19/43] gnu: ghc-setenv: New variable.

[Eric Bavier]

On Thu, 15 Oct 2015 14:21:13 +0200
Paul van der Walt <address@hidden> wrote:

> * gnu/packages/haskell.scm (ghc-setenv): New variable.
> 
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index cb2af0a..ad6547b 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -20,7 +20,7 @@
>  
>  (define-module (gnu packages haskell)
>    #:use-module (ice-9 regex)
> -  #:use-module ((guix licenses) #:select (bsd-3 lgpl2.1))
> +  #:use-module ((guix licenses) #:select (bsd-3 lgpl2.1 expat))
>    #:use-module (guix packages)
>    #:use-module (guix download)
>    #:use-module (guix utils)
> @@ -592,6 +592,29 @@ for encoding UTF8 strings to Word8 lists and back, and 
> for reading and writing
>  UTF8 without truncation.")
>      (license bsd-3)))
>  
> +(define-public ghc-setenv
> +  (package
> +    (name "ghc-setenv")
> +    (version "0.1.1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/setenv/setenv-";
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0cnbgrvb9byyahb37zlqrj05rj25v190crgcw8wmlgf0mwwxyn73"))))
> +    (build-system haskell-build-system)
> +    (home-page
> +     "http://hackage.haskell.org/package/setenv";)

Please put the string on the same line as a field name.

> +    (synopsis
> +     "A cross-platform library for setting environment variables")

Ditto.  (Note: A realize the patch on the wip-haskell-platform-7.10.2-a
is slightly different, but the same issues are there)

> +    (description
> +     "A cross-platform library for setting environment variables.")

In both the synopsis and the description, we don't really care about
the "cross-platform" nature of this package.  Could you adjust the
wording a bit?

`~Eric