Re: [PATCH 2/2] gnu: Add esmtp.

[Thompson, David]

On Tue, Nov 3, 2015 at 9:54 AM, Andy Wingo <address@hidden> wrote:
> * gnu/packages/mail.scm (esmtp): New public variable.
> ---
>  gnu/packages/mail.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index 9a70341..dfc8ec9 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -30,6 +30,7 @@
>    #:use-module (gnu packages base)
>    #:use-module (gnu packages backup)
>    #:use-module (gnu packages bash)
> +  #:use-module (gnu packages bison)
>    #:use-module (gnu packages curl)
>    #:use-module (gnu packages cyrus-sasl)
>    #:use-module (gnu packages databases)
> @@ -44,6 +45,7 @@
>    #:use-module (gnu packages gsasl)
>    #:use-module (gnu packages gtk)
>    #:use-module (gnu packages guile)
> +  #:use-module (gnu packages flex)
>    #:use-module (gnu packages libcanberra)
>    #:use-module (gnu packages libidn)
>    #:use-module (gnu packages linux)
> @@ -70,6 +72,7 @@
>                            (expat . license:expat)))
>    #:use-module (guix packages)
>    #:use-module (guix download)
> +  #:use-module (guix git-download)
>    #:use-module (guix utils)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system perl)
> @@ -955,4 +958,41 @@ be able to post electronic mail where mail functionality 
> may not be that
>  program's primary purpose.")
>      (license (list lgpl2.1+ gpl2+))))
>
> +(define-public esmtp
> +  (package
> +    (name "esmtp")
> +    (version "1.2")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/andywingo/esmtp.git";)
> +             (commit "01bf9fc")))
> +       (sha256
> +        (base32
> +         "1ay282rrl92h0m0m8z5zzjnwiiagi7c78aq2qvhia5mw7prwfyw2"))
> +       (file-name (string-append name "-" version "-checkout"))))
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-before
> +                   'configure 'autoconf
> +                   (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("bison" ,bison)
> +       ("flex" ,flex)
> +       ("libesmtp" ,libesmtp)

Should this be a regular input instead?

> +       ("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)))
> +    (home-page "http://www.stafford.uklinux.net/libesmtp/";)

Wrong home page?

> +    (synopsis "Relay-only mail transfer agent (MTA)")
> +    (description "Esmtp is a simple relay-only mail transfer agent built 
> using
> +libESMTP.  It sends e-mail via a remote SMTP server using credentials from 
> the
> +user's @file{$HOME/.esmtprc} configuration file; see the @command{esmtprc} 
> man
> +page for more on configuration.  This package also provides minimal
> +compatibility shims for the @command{sendmail}, @command{mailq}, and
> address@hidden commands.")
> +    (license gpl2+)))
> +
>  ;;; mail.scm ends here
> --
> 2.5.0
>
>

LGTM sans those minor nits.

- Dave