Re: [PATCH 1/2] gnu: Add qtkeychain.

[Ludovic Courtès]

Efraim Flashner <address@hidden> skribis:

> On Tue, 10 Nov 2015 19:07:20 +0100
> address@hidden (Ludovic Courtès) wrote:
>
>> Efraim Flashner <address@hidden> skribis:
>> 
>> > On Thu, 05 Nov 2015 22:28:42 +0100
>> > address@hidden (Ludovic Courtès) wrote:
>> >  
>> >> Efraim Flashner <address@hidden> skribis:
>> >>   
>> >> > * gnu/packages/qt.scm (qtkeychain): New variable.    
>> >> 
>> >> [...]
>> >>   
>> >> > +       (modify-phases
>> >> > +         %standard-phases    
>> >> 
>> >> ‘%standard-phases’ goes on the previous line.
>> >>   
>> >> > +         (add-before
>> >> > +          'configure 'set-qt-trans-dir
>> >> > +           (lambda _
>> >> > +             (substitute* "CMakeLists.txt"
>> >> > +              (("\\$\\{qt_translations_dir\\}")
>> >> > +                
>> >> > "${CMAKE_INSTALL_PREFIX}/share/qtkeychain/translations")))))))    
>> >> 
>> >> Is Qt able to find translations installed there?  Is some environment
>> >> variable needed to tell it where to look for them?  
>> >
>> > I don't really know.  
>> 
>> Could you check by running it with a non-English locale listed that
>> appears in the ‘translations’ directory?

[...]

> It works! I did `export LANG=de` and then
> ran /./gnu/store/...owncloud/bin/owncloud, and I got a German popup telling
> me there was no associated keychain and I had to enter the password myself.

Good!

So I think, with the tiny stylistic issues I reported fixed, you
can push.

Thank you for your patience!

Ludo’.