Re: Lint on line

[Ludovic Courtès]

Leo Famulari <address@hidden> skribis:

> What is the recommended way to handle the following warning?
>
> "gnu/packages/firmware.scm:33:12: ath9k-htc-firmware-1.4.0: the source
> file name should contain the package name"

Like this:

diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm
index 97f2975..271fb49 100644
--- a/gnu/packages/firmware.scm
+++ b/gnu/packages/firmware.scm
@@ -38,6 +38,7 @@
               (sha256
                (base32
                 "16jbj8avg5jkgvq5lxm0hdxxn4c3zn7fx8b4nxllvr024apk9w23"))
+              (file-name (string-append name "-" version "-checkout"))
               (patches (list (search-patch 
"ath9k-htc-firmware-objcopy.patch")))))
     (build-system gnu-build-system)
     (arguments

I’ll push this one.  ;-)

The goal of this rule is to make sure that checkouts are given
meaningful names.  This does not make any functional difference, but it
helps keep the store tidy.

Thanks,
Ludo’.