Re: [PATCH] gnu: Move pkg-config to native inputs.

[Ludovic Courtès]

Mathieu Lirzin <address@hidden> skribis:

> Thanks to Ludo's work on Guix lint online.

Note that, for this particular checker, you may find it more convenient
to use M-x guix or M-x compile guix lint -c inputs-should-be-native RET
(runs in 1.5 second on my laptop.)

> I have made a patch but I don't know if this is safe to push it on
> master so I prefer requesting advices before.

Such changes usually require rebuilds, and a lot of them in the case of
GLib and PulseAudio.

There are some cases where such a change requires zero rebuilds though.
You can check by running, say,

  guix build glib -n

after making the change, and see if the thing would be rebuilt or if it
would be downloaded/is already on disk.  In the latter case, this means
that the change does not entail any rebuild and is safe.

> From 6a8f2286e307d5b77af3a546d5113c44bac13804 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <address@hidden>
> Date: Mon, 23 Nov 2015 10:44:53 +0100
> Subject: [PATCH] gnu: Move pkg-config to native inputs.
>
> * gnu/packages/glib.scm (gobject-introspection)[native-inputs]: Move
> pkg-config from inputs.
> * gnu/packages/pulseaudio.scm (libsndfile, libsamplerate)
> (pulseaudio)[native-inputs]: Likewise.
> * gnu/packages/xiph.scm (ao)[native-inputs]: Likewise.
> * gnu/packages/xorg.scm (xf86-video-geode)[native-inputs]: Likewise.

[...]

> -       ("pkg-config" ,pkg-config)
>         ("python-2" ,python-2)))
>      (native-inputs
> -     `(("glib" ,glib "bin")))
> +     `(("glib" ,glib "bin")
> +       ("pkg-config" ,pkg-config)))

Most likely entails a rebuild so I’d push it to core-updates.

> --- a/gnu/packages/pulseaudio.scm
> +++ b/gnu/packages/pulseaudio.scm
> @@ -58,8 +58,9 @@
>      (inputs
>       `(("libvorbis" ,libvorbis)
>         ("libogg" ,libogg)
> -       ("flac" ,flac)
> -       ("pkg-config" ,pkg-config)))
> +       ("flac" ,flac)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))

This one might not entail a rebuild.  Please double-check, and send to
master if there’s no rebuild, core-updates otherwise.

> @@ -87,7 +88,8 @@ for reading and writing new sound file formats.")
>                (base32
>                 "01hw5xjbjavh412y63brcslj5hi9wdgkjd3h9csx5rnm8vglpdck"))))
>      (build-system gnu-build-system)
> -    (inputs `(("pkg-config" ,pkg-config)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
>      (propagated-inputs

Most likely no rebuilds, so same story here.

> @@ -162,13 +164,14 @@ rates.")
>         ("dbus" ,dbus)
>         ("glib" ,glib)
>         ("intltool" ,intltool)
> -       ("pkg-config" ,pkg-config)
>         ("m4" ,m4)
>         ("libltdl" ,libltdl)
>         ("fftwf" ,fftwf)
>         ("avahi" ,avahi)
>         ("eudev" ,eudev)           ;for the detection of hardware audio 
> devices
>         ("check" ,check)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))

Most likely a rebuild, so core-updates.

> --- a/gnu/packages/xiph.scm
> +++ b/gnu/packages/xiph.scm
> @@ -165,9 +165,11 @@ stereo encoding, and voice activity detection.")
>      ;; XXX: Should back-ends be pushed to different outputs?  For instance,
>      ;; "out" would include only the ALSA back-end, while "pulse" would
>      ;; contain 'lib/ao/plugins-4/libpulse.*'.
> -    (inputs `(("pkg-config" ,pkg-config)
> -              ("alsa-lib" ,alsa-lib)
> -              ("pulseaudio" ,pulseaudio)))
> +    (inputs
> +     `(("alsa-lib" ,alsa-lib)
> +       ("pulseaudio" ,pulseaudio)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
>      (synopsis "Cross platform audio library")

OK for master because only 19 packages depend on ao.

> --- a/gnu/packages/xorg.scm
> +++ b/gnu/packages/xorg.scm
> @@ -2710,8 +2710,8 @@ framebuffer device.")
>             "19y13xl7yfrgyis92rmxi0ld95ajgr5il0n9j1dridwzw9aizz1q"))
>          (patches (list (search-patch "xf86-video-geode-glibc-2.20.patch")))))
>      (build-system gnu-build-system)
> -    (inputs `(("pkg-config" ,pkg-config)
> -              ("xorg-server" ,xorg-server)))
> +    (inputs `(("xorg-server" ,xorg-server)))
> +    (native-inputs `(("pkg-config" ,pkg-config)))
>      (supported-systems
>       ;; This driver is only supported on i686 systems.
>       (filter (lambda (system) (string-prefix? "i686-" system))

OK for master.

Thanks!

Ludo’.