Re: [PATCH] gnu: Add myrepos.

[Kyle Meyer]

Ricardo Wurmus <address@hidden> writes:

[...]

> You should add a ‘(file-name ...)’ expression here, because the tarball
> does not include the name of the package:
>
>    (file-name (string-append name "-" version ".tar.gz"))

OK.

>> +       #:make-flags (list (string-append "DESTDIR=" (assoc-ref %outputs 
>> "out"))
>> +                          "PREFIX=")))
>
> Is it really correct to set DESTDIR and unset PREFIX?  I thought setting
> PREFIX would be sufficient.

Right, setting PREFIX works fine.  Myrepo's Makefile forms the path as
"${DESTDIR}${PREFIX}", so the end result should be the same.  I'm not
sure why I decided setting DESTDIR would be better.

Sending an updated patch.  Thanks for the comments.

--
Kyle