Re: [PATCH 1/3] services: Add 'session-environment-service'.

[Ludovic Courtès]

address@hidden (宋文武) skribis:

> Alex Kost <address@hidden> writes:
>
>> 宋文武 (2015-12-02 16:38 +0300) wrote:
>>
>>> +(define (environment-variables->environment-file vars)
>>> +  "Return a file for pam_env(8) that contains environment variables VARS."
>>> +  (apply mixed-text-file "environment"
>>> +         (fold-right (lambda (pair result)
>>> +                       (cons* (car pair) "=" (cdr pair) "\n" result))
>>> +                     '() vars)))
>>
>> Hm, car and cdr.  Wouldn't it be clearer to do it like this:
>>
>>   (map (match-lambda
>>          ((name . value)
>>           (string-append name "=" value "\n")))
>>        vars)
> Yes, match-lambda is more clear, thanks!

Indeed.  :-)

> From 0ce1986d4cfca3d40bed4aaf93942cf9caaefb60 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <address@hidden>
> Date: Wed, 2 Dec 2015 19:59:29 +0800
> Subject: [PATCH] services: Add 'session-environment-service'.
>
> * gnu/services/base.scm (session-environment-service): New procedure.
> (session-environment-service-type): New variable.
> (environment-variables->environment-file): New procedure.

LGTM, thanks!

Ludo’.