Re: [PATCH 1/9] gnu: Add ttfautohint.

[Alex Kost]

address@hidden (2016-04-06 07:32 +0300) wrote:

> From: Eric Bavier <address@hidden>
>
> * gnu/packages/fontutils.scm (ttfautohint): New variable.
> * gnu/packages/patches/ttfautohint-source-date-epoch.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.
> ---
>  gnu-system.am                                      |  1 +
>  gnu/packages/fontutils.scm                         | 36 ++++++++++-
>  .../patches/ttfautohint-source-date-epoch.patch    | 70 
> ++++++++++++++++++++++
>  3 files changed, 106 insertions(+), 1 deletion(-)
>  create mode 100644 gnu/packages/patches/ttfautohint-source-date-epoch.patch
[...]
> +(define-public ttfautohint
> +  (package
> +    (name "ttfautohint")
> +    (version "1.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://savannah/freetype/ttfautohint-"
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32
> +         ;; 
> /gnu/store/5kzmy7061aimljpga9qfz49227283sfr-ttfautohint-1.5.tar.gz
        ^^^^^^^^^^
Leftover line?

> +         "1lgghck46p33z3hg8dnl76jryig4fh6d8rhzms837zp7x4hyfkv4"))
> +       (patches (map search-patch 
> '("ttfautohint-source-date-epoch.patch")))))

Since it's just a single patch, I don't see a reason to use 'map' here.

> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("flex" ,flex)
> +       ("bison" ,bison)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("freetype" ,freetype)
> +       ("harfbuzz" ,harfbuzz)))
> +    (arguments
> +     `(#:configure-flags '("--with-qt=no"))) ;no gui
> +    (synopsis "Automated font hinting")
> +    (description
> +     "ttfautohint provides a 99% automated hinting process and a platform for
> +finely hand-hinting the last 1%.  It is ideal for web fonts and supports many
> +scripts.")
> +    (license license:gpl2+)             ;or FreeType license

Or FreeType?  Sorry, what does it mean?  If some files are under GPL2+
and some under FreeType, then why don't you use a list of licenses?

-- 
Alex