Re: [PATCH] gnu: powertop: Patch absolute file names.

[Mathieu Lirzin]

Ricardo Wurmus <address@hidden> writes:

> Mathieu Lirzin <address@hidden> writes:
>
>> * gnu/packages/linux.scm (powertop)[inputs]: Add kmod.
>> [arguments]: Patch absolute file names.  Before that launching powertop
>> was failing because 'modprobe' was not found.
>
> Looks good to me, but I have one thing to nitpick below.
>
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             (let ((kmod (assoc-ref inputs "kmod")))
>> +               (substitute* (find-files "src" ".*\\.cpp" )
>> +                 (("/sbin/modprobe") (string-append kmod "/bin/modprobe"))
>> +                 ;; These programs are only needed to calibrate, so using
>> +                 ;; relative file names avoids adding extra inputs.  When 
>> they
>> +                 ;; are missing powertop gracefully handle it.
>
> Should it not be “handles”?

Indeed you are right. :)

Thanks for your review.

-- 
Mathieu Lirzin