[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add thinkfan.
From: |
Nicolas Goaziou |
Subject: |
Re: [PATCH] Add thinkfan. |
Date: |
Wed, 04 May 2016 00:12:48 +0200 |
Hello,
Leo Famulari <address@hidden> writes:
> Can you add a brief comment explaining this flag?
Done.
> Also, can you add a phase that installs the "rcscripts"? They will be
> useful for Guix users on foreign distros.
Done.
> I'm not sure where to install them. Since they will probably have to be
> copied or symlinked out of ~/.guix-profile anyways, how about installing
> them into 'share/misc'?
>
> I'm open to better ideas!
What about share/thinkfan instead? I changed the patch accordingly. Feel
free to use share/misc instead if you think this is better.
>> + (synopsis "Simple fan control program")
>
> Is it specific to ThinkPads?
No, it isn't. Quoting README:
Thinkfan is a simple, lightweight fan control program. Originally designed
specifically for IBM/Lenovo Thinkpads, it now supports any kind of system via
the sysfs hwmon interface (/sys/class/hwmon).
Here is the updated patch. Thank you for the review.
Regards,
--
Nicolas Goaziou 0x80A93738
0001-gnu-Add-thinkfan.patch
Description: add thinkfan (take 2)
- Re: [PATCH] Add thinkfan., Leo Famulari, 2016/05/01
- Re: [PATCH] Add thinkfan., Kei Yamashita, 2016/05/01
- Re: [PATCH] Add thinkfan.,
Nicolas Goaziou <=
- Re: [PATCH] Add thinkfan., Leo Famulari, 2016/05/06
- Re: [PATCH] Add thinkfan., Nicolas Goaziou, 2016/05/06
- Re: [PATCH] Add thinkfan., Leo Famulari, 2016/05/06
- Re: [PATCH] Add thinkfan., Nicolas Goaziou, 2016/05/07
- Re: [PATCH] Add thinkfan., Ludovic Courtès, 2016/05/09
- Re: [PATCH] Add thinkfan., Nicolas Goaziou, 2016/05/10
- Re: [PATCH] Add thinkfan., Ludovic Courtès, 2016/05/11