[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] entr-3.5
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] entr-3.5 |
Date: |
Wed, 11 May 2016 18:19:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hello, and welcome!
Matthew Jordan <address@hidden> skribis:
> I'm relatively new to guix, spent the first couple
> days getting used to running it in my VM. Loving it so far. Since I'm
> not sure what to expect I decided to package a simple program that I
> find quite handy. Let me know if I should change anything.
>
> Also note that I followed "8.5 Submitting Patches" of the "GNU Guix
> Reference Manual"
Great! There’s a couple of things that this section doesn’t clearly
mention, such as copyright notices—there’s room for improvement. ;-)
> From 5b33ed530e472008bddf85a2f23b3fa9857b365e Mon Sep 17 00:00:00 2001
> From: Matthew Jordan <address@hidden>
> Date: Wed, 11 May 2016 09:25:13 -0400
> Subject: [PATCH] Added package entr.
Pushed as 5d38aa0 with these minor changes:
1. Added a copyright notice for you (let me know if you think it’s
incorrect!).
2. Added a ‘remove-fhs-file-names’ phase to remove hard-coded
references to /bin/cat and /usr/bin/clear.
3. Added the file to gnu/local.mk.
4. Added a ChangeLog-style commit log.
Thank you!
Ludo’.
- [PATCH] entr-3.5, Matthew Jordan, 2016/05/11
- Re: [PATCH] entr-3.5,
Ludovic Courtès <=