Re: 01/01: gnu: vlc: Update to 2.2.4 [fixes CVE-2016-5108].

[Ludovic Courtès]

address@hidden (Efraim Flashner) skribis:

> commit a134cc8e93428bf6f309de54e5c944705d30418f
> Author: Efraim Flashner <address@hidden>
> Date:   Wed Jun 8 17:11:06 2016 +0300
>
>     gnu: vlc: Update to 2.2.4 [fixes CVE-2016-5108].
>     
>     * gnu/packages/video.scm (vlc): Update to 2.2.4.
>     [inputs]: Remove qt, add qtbase.

IMO it would have been best to make it two separate patches.

>     [arguments]: Add phase to disable display test.

> +         (add-before 'configure 'remove-visual-tests
> +           ;; Some of the tests require using the display to test out VLC,
> +           ;; which fails in our sandboxed build system

Usually this is addressed by starting Xvfb (there are several examples
of that.)  Would it work here?

> +             (substitute* "test/run_vlc.sh"
> +                          (("./vlc --ignore-config") "echo"))

What happened with indentation?  :-)

Thanks for the security update!

Ludo’.