Re: [PATCH] Add msgpack

[Leo Famulari]

On Sat, Jun 11, 2016 at 11:24:23PM -0500, Lukas Gradl wrote:
> Oh, that is true.  I searched around, but I could not find anything
> about zbuffer.h[pp].  I am not sure what it is used for.  FWIW, it is
> only referenced in src/Makefile, src/Makefile.in, src/Makefile.am
> CMakeLists.txt and in the tests:

[...]

> Judging from this, I am inclined to think that msgpack does not use
> these two headers for anything but tests.  But I am not sure about
> this.

I think that another application would call the zbuffer functions,
although the string 'zbuffer' does not exist in the opendht source code.
But, we should make sure msgpack will work for other calling
applications that might be added later.

On #guix, bavier suggested we patch 'msgpack.pc.in'. Specifically, we
should append the include flag to 'Cflags:' and create a 'Libs.private:'
field for the -L and -l flags. There are some examples in
'gnu/packages'.

More details on the IRC log:
https://gnunet.org/bot/log/guix/2016-06-13#T1056507

I've cc-ed Eric since I don't know much about pkg-config.

> FWIW, I looked at what other distributions do:
> 
> The Arch PKGBUILD does not refer to Zlib at all:
> https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/msgpack-c
> 
> Gentoo has Zlib for tests:
> https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/msgpack/msgpack-1.1.0.ebuild
> 
> Debian seems to not refer to Zlib:
> https://packages.debian.org/jessie/libmsgpackc2
> https://packages.debian.org/jessie/libmsgpack3
> https://packages.debian.org/jessie/libmsgpack-dev

I think that zlib is so ubiquitous that it's a safe assumption it will
can be found in the environment on the '/usr' distros.

> This Nix expression does not mention zlib:
> https://github.com/NixOS/nixpkgs/blob/f199be0fafcff0713dd4340b4373e575294aad58/pkgs/development/libraries/libmsgpack/generic.nix#L41

An oversight? I don't know the Nix equivalent of `guix refresh -l` to
check which of their packages use msgpack.