[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] Update Git to 2.9.0
From: |
Leo Famulari |
Subject: |
Re: [PATCH 0/1] Update Git to 2.9.0 |
Date: |
Sun, 19 Jun 2016 13:41:28 -0400 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Sun, Jun 19, 2016 at 04:01:25PM +0200, Ludovic Courtès wrote:
> Sounds reasonable; ‘git commit’ still honors ‘commit.gpgsign’, right?
Yes, that still works as expected, at least in the simple case.
> > The commit text seems to imply that `git rebase` would no longer re-sign
> > commits, but that's not the case from my tests.
>
> OK. It would be bad if ‘git rebase’ would silently discard signatures.
> Thanks for paying attention to this!
I'm not sure what you mean exactly. If you rebase some signed commits,
the commits whose history changes will lose their signatures, because
they are no longer the same commits. But, I noticed this with previous
versions of Git also.
Because we never rewrite history once it's been on Savannah's master
branch, the only commits that need to be re-signed after rebase are my
own commits, so far seen only on my local repo. I've never needed to
rebase others' commits, so their signatures are unaffected.
Does that make sense?