[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Clean all .go in clean-go
From: |
Leo Famulari |
Subject: |
Re: [PATCH] Clean all .go in clean-go |
Date: |
Fri, 16 Sep 2016 02:00:17 -0400 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Fri, Sep 16, 2016 at 12:15:40AM -0500, Eric Bavier wrote:
> Another issue that I thought of that's posed by these stray .go files,
> which isn't only a problem when acting as a wizard: introducing a new
> module import when adding a package, only to have that module
> moved/renamed before pushing your change. I suppose it is a corner
> case, but it did happen to me recently, in 2e3f18511, which 宋文武
> kindly fixed in 19b2ea1b6. The problem was that between the time I
> originally packaged tomb and the time I pushed the commit,
> gnu/packages/zsh.scm was consolidated into gnu/packages/shells.scm. I
> had done a `make clean-go && make` before pushing, as I always do, but
> since clean-go didn't remove gnu/packages/zsh.go the subsequent `make`
> didn't complain of a missing module.
I accidentally did this to myself in c41d97bed6 (gnu: mupdf: Update to
1.9a.).