[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] document ocaml-build-system
From: |
Julien Lepiller |
Subject: |
Re: [PATCH] document ocaml-build-system |
Date: |
Sun, 29 Jan 2017 10:16:15 +0100 |
pushed. Sorry about the two commits, I forgot to add guix.texi after I
made a last change.
On Sun, 29 Jan 2017 00:49:43 +0100
address@hidden (Ludovic Courtès) wrote:
> Hi!
>
> Julien Lepiller <address@hidden> skribis:
>
> > From 8854480a48e8096bf6bf8d94b3695fb049720038 Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <address@hidden>
> > Date: Sat, 28 Jan 2017 12:11:42 +0100
> > Subject: [PATCH] doc: Document ocaml-build-system.
> >
> > * doc/guix.texi (Build Systems) [ocaml-build-system]: New
> > definition.
>
> Awesome! Minor comments:
>
> > address@hidden {Scheme Variable} ocaml-build-system
>
> Write “OCaml” (not “ocaml” or something else), “Guix”, and “OASIS”.
>
> > +This variable is exported by @code{(guix build-sytem ocaml)}. It
> > is implements
>
> s/is//
>
> > +a build procedure for ocaml packages, which consists of choosing
> > the correct
>
> Since this is the first occurrence: s/ocaml/@uref{https://ocaml.org,
> OCaml}/
>
> > +was generated by oasis and will take care of setting the prefix
> > and enabling
>
> s/oasis/@uref{http://oasis.forge.ocamlcore.org/, OASIS}/
>
> > +Finaly, some packages do not have these files and use a somewhat
> > standard
> ^
> “Finally”
>
> OK with these changes.
>
> Thank you!
>
> Ludo’.