Re: [PATCH 09/10] gnu: Add ocaml-js-build-tools.

[Julien Lepiller]

On Mon, 30 Jan 2017 23:23:27 +0100
address@hidden (Ludovic Courtès) wrote:

> Julien Lepiller <address@hidden> skribis:
> 
> > On Mon, 30 Jan 2017 10:22:13 +0100
> > address@hidden (Ludovic Courtès) wrote:
> >  
> >> Julien Lepiller <address@hidden> skribis:
> >>   
> >> > +++ b/gnu/packages/patches/ocaml-janestreet-fix-libdir.patch
> >> > @@ -0,0 +1,39 @@
> >> > +This patch adds a --libdir option to opam-installer so it
> >> > installs the plugin +in the specified directory rather than in
> >> > the default one (ocaml's directory in +the store, which is
> >> > forbidden). +diff -aur package.pristine/Makefile
> >> > package.new/Makefile +--- package.pristine/Makefile
> >> > 2016-02-06 01:55:14.650150309 +0100 ++++
> >> > package.new/Makefile     2016-02-06 01:57:56.012174364 +0100
> >> > +@@ -29,26 +29,26 @@
> >> > +        ocaml -I js-utils js-utils/gen_install.ml
> >> > +
> >> > + install: $(NAME).install
> >> > +-       opam-installer -i --prefix $(PREFIX) $(NAME).install
> >> > ++       opam-installer -i --prefix $(PREFIX) --libdir $(LIBDIR)
> >> > $(NAME).install +
> >> > + uninstall: $(NAME).install
> >> > +-       opam-installer -u --prefix $(PREFIX) $(NAME).install
> >> > ++       opam-installer -u --prefix $(PREFIX) --libdir $(LIBDIR)
> >> > $(NAME).install    
> >> 
> >> On second thought, I think it’d be simpler and more maintainable
> >> to do this as a substitution in the snippet.
> >> 
> >> WDYT?
> >> 
> >> (It will also avoid ‘guix lint’ complaints about the patch file
> >> name not matching the package name.  :-))
> >> 
> >> Ludo’.  
> >
> > Sure, here it is :)
> >
> > From 8cd3ba3a3f9702a89f8f52c75c33d3d02f20f60b Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <address@hidden>
> > Date: Fri, 30 Dec 2016 16:27:27 +0100
> > Subject: [PATCH 2/2] gnu: Add ocaml-bin-prot.
> >
> > * gnu/packages/ocaml.scm (ocaml-bin-prot): New variable.  
> 
> Wait, I was commenting on ocaml-js-build-tools, not on ocaml-bin-prot:
> 
>   https://lists.gnu.org/archive/html/guix-devel/2017-01/threads.html#02134
> 
> Could it be that you’re replying to the wrong message?  :-)
> 
> Ludo’.

I was replying to the correct message, but not with the correct patch.

0001-gnu-Add-ocaml-js-build-tools.patch
Description: Text Data