Re: [PATCH 3/7] gnu: Add python2-ruamel.ordereddict

[ng0]

Hi,

Maxim Cournoyer writes:

> Hi,
>
> I have a few of comments for this one too.
>
> address@hidden writes:
>
>> From: ng0 <address@hidden>
>>
>> * gnu/packages/python.scm (python2-ruamel.ordereddict): New variable.
>> ---
>>  gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index f6516d26b..cef9d2a8c 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -583,6 +583,34 @@ the Python logging module that outputs records using 
>> terminal colors.")
>>        (native-inputs
>>         `(("python2-setuptools" ,python2-setuptools))))))
>>  
>> +(define-public python2-ruamel.ordereddict
>> +  (package
>> +    (name "python2-ruamel.ordereddict")
>> +    (version "0.4.9")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "ruamel.ordereddict" version))
>> +       (sha256
>> +        (base32
>> +         "1xmkl8v9l9inm2pyxgc1fm5005yxm7fkd5gv74q7lj1iy5qc8n3h"))))
>> +    (build-system python-build-system)
>> +    ;; XXX: https://bitbucket.org/ruamel/ordereddict/issues/2
>
> Maybe the comment should say "No ordereddict python3 build available" ?
>
>> +    (arguments
>> +     `(#:python ,python-2))
>> +    (inputs
>> +     `(("python2-setuptools" ,python2-setuptools)))
>
> Unnecessary, part of our Python2 package.

Yes, as I wrote I did not review it again. This is from back in
September, before the build system was changed. I forgot about
tinycm in the list-email: This is dropped too. I have no way to
fix this. The patches will still apply (rebased on master), so
anyone who wants to fix this can fix these python packages.

>> +    (home-page "https://bitbucket.org/ruamel/ordereddict";)
>> +    (synopsis "Version of @code{dict} that keeps keys in insertion
>> +resp. sorted order")
>> +    (description
>> +     "This is an implementation of an ordered dictionary with Key
>> +Insertion Order and Key Value Insertion Order.  The standard library
>
> Is the capitalization of Key Insertion Order/Key Value Insertion Order
> really necessary? Also, there are 2 spaces following the period.
>
>> +module OrderedDict, implemented later, implements a subset of
>> +ordereddict functionality.  Sorted dictionaries are also provided.
>
> 2 spaces following the period here also. Is this intended?
>
>> +Currently only with Key Sorted Order.")
>
> Again, I'm not sure about the proper capitalization here.
>
> Thanks,
>
> Maxim


-- 
ng0 . https://www.inventati.org/patternsinthechaos/