[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3
From: |
Danny Milosavljevic |
Subject: |
Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3 |
Date: |
Sat, 4 Feb 2017 18:28:05 +0100 |
Hi,
On Mon, 30 Jan 2017 11:06:49 +0800
address@hidden wrote:
> -(define* (manifest-lookup-package manifest name #:optional version)
> +(define* (manifest-lookup-package manifest name #:optional version output)
> "Return as a monadic value the first package or store path referenced by
> MANIFEST that is named NAME and optionally has the given VERSION prefix, or
> #f
> if not found."
Please update the docstring too.
> + (if output
> + (string-suffix? output version*)
> #t))))
Should that include the separator between the parts? Otherwise it could maybe
have false positives...