[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3
|
From: |
Huang\, Ying |
|
Subject: |
Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3 |
|
Date: |
Sun, 05 Feb 2017 07:42:38 +0800 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hi, Danny,
Thanks for comments!
Danny Milosavljevic <address@hidden> writes:
> Hi,
>
> On Mon, 30 Jan 2017 11:06:49 +0800
> address@hidden wrote:
>
>> -(define* (manifest-lookup-package manifest name #:optional version)
>> +(define* (manifest-lookup-package manifest name #:optional version output)
>> "Return as a monadic value the first package or store path referenced by
>> MANIFEST that is named NAME and optionally has the given VERSION prefix, or
>> #f
>> if not found."
>
> Please update the docstring too.
Sure.
>> + (if output
>> + (string-suffix? output version*)
>> #t))))
>
> Should that include the separator between the parts? Otherwise it
> could maybe have false positives...
OK.
Best Regards,
Huang, Ying