Re: [PATCH] gnu: font-gnu-unifont: Call mkfontdir for pcf output

[Huang\, Ying]

Hi, Wenwu,

Thanks for comments!

address@hidden (宋文武) writes:

> address@hidden writes:
>
>> * gnu/packages/fonts.scm (font-gnu-unifont): call mkfontdir for pcf output.
>>
>> Signed-off-by: "Huang, Ying" <address@hidden>
>> ---
>>  gnu/packages/fonts.scm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
>> index 1f6d1d0c3..088a6bec9 100644
>> --- a/gnu/packages/fonts.scm
>> +++ b/gnu/packages/fonts.scm
>> @@ -671,13 +671,15 @@ languages, plus Greek and Cyrillic.")
>>                         (string-append "PCFDEST=" pcf)
>>                         (string-append "CONSOLEDEST=" psf)
>>                         "install")
>> +              (system* "mkfontdir" pcf)
>
> This will create 'share/fonts/misc/fonts.dir' in the 'pcf' output of
> font-gnu-unifont package.  When multiple packages have this file,
> collisions occour and then I guess it won't work as expected.

I think so too.

> The right
> place to create this file is the 'fonts-dir-file' hook in profiles.scm,
> currently it does 'mkfontscale' and 'mkfontdir' only for truetype fonts
> under 'share/fonts/truetype', which can be extended for each directory
> under 'share/fonts'.  What do you think?

I think that is better.  I have thought about that before.  But I didn't
know whether that is necessary in general at that time.

Best Regards,
Huang, Ying