[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3 |
Date: |
Mon, 06 Feb 2017 02:08:11 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.1.1 |
address@hidden writes:
> From: Huang Ying <address@hidden>
>
> Gtk+3 now have multiple outputs, so the gtk-query-immodules-3.0 should be find
> in bin output.
Ah, I was wondering why this broke! Thanks for investigating it.
> The fix works, but appears hacky, because I haven't read much guix source
> code, so I don't know the best solution.
It’s only hacky because I tried to reuse the code for both versions of
Gtk. Maybe “gtk+-2” should also get a “bin” output…?
This is acceptable with the changes Danny suggested. Maybe we can find
a way to make this prettier in the future.
Thanks again for taking the time to investigate and fix it, and to
submit a patch! I’m very grateful for this contribution.
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net