Re: [PATCH 5/7] gnu: Add gnome-disk-utility.

[Ludovic Courtès]

Hello!

Maxim Cournoyer <address@hidden> skribis:

> David Craven <address@hidden> writes:

[...]

>> +       (modify-phases %standard-phases
>> +         (add-before 'configure 'fix-docbook
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             (substitute* "doc/man/Makefile.in"
>> +               
>> (("http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl";)
>> +                (string-append (assoc-ref inputs "docbook-xsl")
>> +                               "/xml/xsl/docbook-xsl-"
>> +                               ,(package-version docbook-xsl)
>> +                               "/manpages/docbook.xsl")))
>> +             (setenv "XML_CATALOG_FILES"
>> +                     (string-append (assoc-ref inputs "docbook-xml")
>> +                                    "/xml/dtd/docbook/catalog.xml")))))))
>
> I think it would be more elegant to pass the XML_CATALOG_FILES variable
> by using the #;make-flags keyworded argument. XML_CATALOG_FILES can also
> contain both the xml & xsl catalogs (the items are to be space
> separated), which means no substitute* call are needed. See the commit
> aef5055ff9 which does that.

Alternately, adding libxml2 as an input should just give you
automatically the XML_CATALOG_FILES definition.

>> +    (home-page "https://git.gnome.org/browse/gnome-disk-utility";)
>> +    (synopsis "Disk management utility for GNOME")
>> +    (description "Disk management utility for GNOME.")
>> +    (license license:gpl2)))
>
> This should be gpl2+ (see files headers, such as:
> https://git.gnome.org/browse/gnome-disk-utility/tree/src/disks/gduapplication.c)

Indeed.

Thank you,
Ludo’.