Re: Broken tests

[Ludovic Courtès]

Hello,

Federico Beffa <address@hidden> skribis:

> On Sat, Feb 11, 2017 at 6:15 PM, David Craven <address@hidden> wrote:
>> Hi!
>>
>>> Revert "import: json: Explicitly ask for JSON data."
>>> This reverts commit 81e0bc1834490a1a8092c75a0733b15c2b407285.
>>
>> I reverted this commit in my local repository for now, it breaks the
>> pypi, crate and some other test I can't recall (gem and/or cpan).
>
> The importers seems to be working as before. I believe that the
> problem is with the tests. They replace the function 'http-fetch', but
> do not replicate the signature of the original function and instead
> use a different one.

Indeed.  Fixed in ce8963c5b7a728257920aeceeb89e40d166d09f4.

Please make sure to run the test suite before changing non-package code.

In general, I think we can agree on reverting changes that break the
tests until a solution is proposed (and once the original author has
been notified, of course).  That sounds like reasonable policy to me.

Thoughts?

Ludo’.