Re: [PATCH 3/3] gnu: Add filezilla.

guix-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] gnu: Add filezilla.

From:	Maxim Cournoyer
Subject:	Re: [PATCH 3/3] gnu: Add filezilla.
Date:	Wed, 15 Feb 2017 13:13:40 -0800

Hi,

While I haven't tried it, the patch looks good to me!

Maxim

On Tue, Feb 14, 2017 at 9:44 PM, <address@hidden> wrote:

Minor thing, and I'm not sure if we have a convention for this, but it'd
be neat to keep the use-module statements ordered alphabetically.

Ordered alphabetically!

Again, I'm under the impression that this should rather be gpl2+. I'd be
happy to be proven wrong otherwise!

+ (properties '((upstream-name . "FileZilla")))))

Otherwise LGTM (haven't tested though).

Updated patch. Thanks

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 2/3] gnu: Add libfilezilla., (continued)
- [PATCH 1/3] gnu: wxwidgets: Fix for Filezilla client., rennes, 2017/02/09
  - Re: [PATCH 1/3] gnu: wxwidgets: Fix for Filezilla client., Leo Famulari, 2017/02/16
    - Re: [PATCH 1/3] gnu: wxwidgets: Fix for Filezilla client., rennes, 2017/02/17
    - Re: [PATCH 1/3] gnu: wxwidgets: Fix for Filezilla client., rennes, 2017/02/17
- [PATCH 3/3] gnu: Add filezilla., rennes, 2017/02/09
  - Re: [PATCH 3/3] gnu: Add filezilla., Maxim Cournoyer, 2017/02/12
    - Re: [PATCH 3/3] gnu: Add filezilla., rennes, 2017/02/15
    - Re: [PATCH 3/3] gnu: Add filezilla., Maxim Cournoyer <=
    - Re: [PATCH 3/3] gnu: Add filezilla., Leo Famulari, 2017/02/16

Prev by Date: Re: [PATCH 1/1] services: Add agetty service.
Next by Date: Re: [PATCH 2/3] gnu: Add libfilezilla.
Previous by thread: Re: [PATCH 3/3] gnu: Add filezilla.
Next by thread: Re: [PATCH 3/3] gnu: Add filezilla.
Index(es):
- Date
- Thread