[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to uni
From: |
Andy Wingo |
Subject: |
Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build |
Date: |
Fri, 24 Feb 2017 14:32:41 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hi :)
On Fri 24 Feb 2017 13:40, "Huang, Ying" <address@hidden> writes:
>> (define (union output inputs)
>> (match inputs
>> ((input)
>> - ;; There's only one input, so just make a link.
>> - (symlink* input output))
>> + ;; There's only one input, so just make a link unless
>> create-all-directory?
This comment should be a full sentence ending with a period, with line
wrapped at 72 columns.
>> + (if (and create-all-directory? (file-is-directory? input))
>> + (union-of-directories output inputs)
>> + (symlink* input output)))
What's the use case? Something that can handle some symlinks in the
tree but not all symlinks in the tree? I think this patch is a bad idea
for union-build because it has a strange effect that's hard to describe
up and down the union (both at the root and at branch directories). I
think it's probably a better idea to go for something more fit to your
purpose and only pull it into union-build once you see yourself needing
it more than once. IMO anyway :)
Andy
- [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build, huang_ying_caritas, 2017/02/17
- [PATCH 2/2] guix: profiles: create fonts.dir/scale for all fonts directories, huang_ying_caritas, 2017/02/17
- Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build, Huang\, Ying, 2017/02/24
- Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build,
Andy Wingo <=
- Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build, Danny Milosavljevic, 2017/02/24
- Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build, Huang\, Ying, 2017/02/24
- Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build, Huang\, Ying, 2017/02/25
- Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build, 宋文武, 2017/02/26
- Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build, Huang\, Ying, 2017/02/27