Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

[Huang\, Ying]

Hi, Andy,

Andy Wingo <address@hidden> writes:

> Hi :)
>
> On Fri 24 Feb 2017 13:40, "Huang, Ying" <address@hidden> writes:
>
>>>    (define (union output inputs)
>>>      (match inputs
>>>        ((input)
>>> -       ;; There's only one input, so just make a link.
>>> -       (symlink* input output))
>>> +       ;; There's only one input, so just make a link unless 
>>> create-all-directory?
>
> This comment should be a full sentence ending with a period, with line
> wrapped at 72 columns.

Sure.

>>> +       (if (and create-all-directory? (file-is-directory? input))
>>> +           (union-of-directories output inputs)
>>> +           (symlink* input output)))
>
> What's the use case?  Something that can handle some symlinks in the
> tree but not all symlinks in the tree?  I think this patch is a bad idea
> for union-build because it has a strange effect that's hard to describe
> up and down the union (both at the root and at branch directories).  I
> think it's probably a better idea to go for something more fit to your
> purpose and only pull it into union-build once you see yourself needing
> it more than once.  IMO anyway :)

The use case is the 2/2 of the patchset,

[PATCH 2/2] guix: profiles: create fonts.dir/scale for all fonts directories

I want to create fonts.dir and fonts.scale for font packages, because
multiple font packages could install fonts into same directory.  This is
done for $GUIX_PROFILE/share/fonts/truetype only before, but now we want
to do that for all font directories in $GUIX_PROFILE/share/fonts.  Do
you have some idea for some better solution?

Best Regards,
Huang, Ying

>
> Andy