[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners pat
From: |
Clément Lassieur |
Subject: |
Re: [PATCH] services: dovecot: Fix unix_listeners and fifo_listeners path types. |
Date: |
Mon, 27 Feb 2017 10:21:09 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.2.1 |
Andy Wingo <address@hidden> writes:
> On Sun 26 Feb 2017 20:42, Clément Lassieur <address@hidden> writes:
>
>> * gnu/services/mail.scm (unix-listener-configuration)[path]
>> (fifo-listener-configuration)[path]: Change type from 'file-name' to
>> 'string'.
>> * doc/guix.texi (Mail Services): Document it.
>
> Why's that? Is the extra checking from the file-name type (that the
> string start with "/") getting in the way of something?
Yes, because the path is also used as the section name (see
http://wiki2.dovecot.org/Services#Service_listeners).
So for example, this code (from gnu/services/mail.scm:445) raises an
error because "lmtp" doesn't start with "/":
(service-configuration
(kind "lmtp")
(listeners
(list (unix-listener-configuration (path "lmtp") (mode "0666")))))
I don't understand how it could work before. Maybe the check wasn't
done.