guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to uni


From: Mark H Weaver
Subject: Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build
Date: Thu, 02 Mar 2017 20:25:24 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Danny Milosavljevic <address@hidden> writes:

> On Fri, 24 Feb 2017 17:13:53 -0500
> Mark H Weaver <address@hidden> wrote:
>
>> If the purpose here is to facilitate mutating anything in the store,
>
> That's not what it does. It's used in the profile hook. 'union-build
> is basically just reused to avoid code duplication. See PATCH 2/2.

I see now.  I withdraw my objection.  Sorry for the delay.

The only remaining issue I see is that the second patch removes error
checking on the status code returned by 'mkfontscale' and 'mkfontdir'.
It would be preferable to retain that.  However, it's not a serious
issue.

     Regards,
       Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]