Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.

[ng0]

On 17-03-02 22:00:47, Clément Lassieur wrote:
> Hi Danny,
> 
> Danny Milosavljevic <address@hidden> writes:
> 
> > Hi,
> >
> > On Tue, 21 Feb 2017 00:53:55 +0100
> > Clément Lassieur <address@hidden> wrote:
> >> +This is a list of two-element tuples, 
> >
> > list of pairs.
> >
> >>where each tuple contains the
> >
> > each pair
> >
> >> +subsystem name and a command (with optional arguments) to execute upon
> >> +subsystem request.
> >> +
> >> +The command @command{sftp-server} implements the SFTP file transfer
> >> +subsystem.
> >> address@hidden
> >> +'(("sftp" "/usr/libexec/sftp-server"))
> >
> > Hmm, that is a list in there, not a two-element tuple:
> >
> > scheme@(guile-user)> (car '(("A" "B")))
> > $1 = ("A" "B")
> > scheme@(guile-user)> (car (car '(("A" "B"))))
> > $3 = "A"
> > scheme@(guile-user)> (cdr (car '(("A" "B"))))
> > $2 = ("B")  <---- should be "B" without the parens for tuples
> >
> > So I suggest either fix the example to be a pair ("sftp" . 
> > "/usr/libexec/sftp-server") or fix the docs.
> 
> Ok.  I'll correct this later, for now I don't want to push this patch,
> I'm waiting for a confirmation from ng0.
> 
> Thanks for the review!
> 

Okay, I've tried to figure out what the correct patches are but now that
I know the fact that subsystems was left out later (or my tree view is
wrong) is strange.

What I take from the discussion is, all is good to go except for
subsystems. I'm okay with reviewing subsystems as an individual patch
later on. For me this works. Push the 3 patches, and send the subsystems
one later as a new discussion-bug.