Re: [PATCH 1/2] doc: Symlink daemon start-up files.

[Ludovic Courtès]

Leo Famulari <address@hidden> skribis:

> On Mon, Jan 16, 2017 at 10:49:32AM +0100, Ludovic Courtès wrote:
>> > On Fri, Nov 18, 2016 at 03:31:24PM -0500, Leo Famulari wrote:
>> > I think we should go back to the "old way" of instructing users to copy
>> > the file...
>> >
>> >> I'd argue it should point to /var/guix/profiles/per-user/root/...
>> >
>> > ... and make the service file execute this path.
>> 
>> Could you send a patch?
>
> I've attached two patches. The first updates the instructions in the
> manual, and the second builds the service files with the '/var/guix...'
> path.
>
> From 62249ac64fb5cd0235bba28197cb7ac697719b83 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <address@hidden>
> Date: Sun, 5 Mar 2017 14:04:34 -0500
> Subject: [PATCH 1/2] Revert "doc: Symlink daemon start-up files."
>
> This reverts commit b7230de54b493da5a78922b4226255763b525a98.
>
> Versions of systemd that supported symlinked service files are not yet widely
> deployed.
>
> See this thread for more information:
> http://lists.gnu.org/archive/html/guix-devel/2017-01/msg01199.html

Could you add this reference in a @c comment in the .texi file?

Otherwise LGTM!

> From b79385c076ba4921fdf5f3ad2af76d3d171515c8 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <address@hidden>
> Date: Sun, 5 Mar 2017 14:33:13 -0500
> Subject: [PATCH 2/2] build: Don't embed absolute paths in .service and .conf
>  service files.
>
> Otherwise, users will be stuck running an old copy of guix and the guix-daemon
> if they copy the service files instead of symlinking them.
>
> * etc/guix-daemon.conf.in, etc/guix-daemon.service.in, 
> etc/guix-publish.conf.in,
> etc/guix-publish.service.in: Expand @localstatedir@ instead of @address@hidden
> * nix/local.mk (etc/guix-%.service, etc/guix-%.conf): Use @localstatedir@
> instead of @address@hidden

OK.

Thanks for addressing this!

Ludo’.