Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.

[Clément Lassieur]

ng0 <address@hidden> writes:

> Ludovic Courtès transcribed 1.1K bytes:
>> Hi Clément,
>> 
>> Clément Lassieur <address@hidden> skribis:
>> 
>> > I think there is a misunderstanding.  I didn't want to push this because
>> > it was not tested, and because subsystems are often useless without
>> > Match, and Match is unsupported.  The pair/list thing is not the
>> > problem.
>> >
>> > And I was waiting for ng0 to test, because he asked for this patch (see
>> > http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), so
>> > I thought he was able to test.
>> >
>> > If ng0 still needs the patch and confirms that it works well, I'm
>> > willing to update it.  Otherwise, let's drop it.
>> 
>> The patch looks like a useful addition.  It would be sad to drop it, no?
>> 
>> If you could add a test to (gnu tests ssh) that would be perfect, but
>> otherwise it LGTM.  Perhaps the default value for ‘subsystems’ should
>> include internal-sftp though, as users probably expect sftp to just work.
>> 
>> I don’t have any issue with using two-element lists; I think the syntax
>> for pairs can be a bit confusing for newcomers to it’s probably better
>> to avoid it in service configuration.
>> 
>> Thanks,
>> Ludo’.
>> 
>
> I'm taking a break currently and only deal with planing things or
> documenting work and future Guix related work, so I won't test this in
> the next 1 or 2 weeks.
> I am fairly sure that sshfs still needs this.
>
> ps Clément: 'them'/'they' are pronouns if you don't know the gender and/or
> prefered pronoun of a person :)

Oh, I apologize.