Re: [PATCH] gnu: Add Xfce Notification Daemon.

[Marius Bakke]

Hi Petter, thanks a lot for this!

The patch looks good, I only have one question (not very familiar with
gtk packaging either, so please excuse my ignorance).


> * gnu/packages/xfce.scm (xfce4-notifyd): New variable.

[...]

> +    (native-inputs
> +     `(("intltool" ,intltool)
> +       ("pkg-config" ,pkg-config)))
> +    (propagated-inputs
> +     `(("glib:bin" ,glib "bin")))

Do you know why glib:bin needs to be propagated here? Looking at
gnome.scm, it's usually a "native-input". If this program requires some
of the executables from that package at runtime, it's better to patch it
with the absolute paths.

Other than that looks great! I'd add an @code{...} wrapper around
"org.freedesktop.Notifications" in the description, but that can be
fixed up before committing, no need for a new patch.

> +    (inputs
> +     `(("gtk+" ,gtk+)
> +       ("libxfce4util" ,libxfce4util)
> +       ("libxfce4ui" ,libxfce4ui)
> +       ("xfconf" ,xfconf)
> +       ("libnotify" ,libnotify)))
> +    (home-page 
> "https://goodies.xfce.org/projects/applications/xfce4-notifyd";)
> +    (synopsis "Show notification bubbles on Xfce")
> +    (description
> +     "The Xfce Notify Daemon (xfce4-notifyd for short) is a smallish program
> +that implements the “server-side” portion of the Freedesktop desktop
> +notifications specification.  Applications that wish to pop up a notification
> +bubble in a standard way can implicitly make use of xfce4-notifyd to do so by
> +sending standard messages over D-Bus using the org.freedesktop.Notifications
> +interface.")
> +    (license gpl2)))

It is indeed version 2 only..

signature.asc
Description: PGP signature