[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: cross-compiling in core-updates
From: |
Andy Wingo |
Subject: |
Re: cross-compiling in core-updates |
Date: |
Tue, 02 May 2017 21:20:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
On Tue 02 May 2017 21:03, Sergei Trofimovich <address@hidden> writes:
> Yay! The following patch makes bash-minimal compile fine!
>
> diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
> index ef22728a9..38aa1786e 100644
> --- a/gnu/packages/bash.scm
> +++ b/gnu/packages/bash.scm
> @@ -213,7 +213,7 @@ without modification.")
> (arguments
> - (let ((args `(#:modules ((guix build gnu-build-system)
> + (let ((args `(,@(package-arguments bash)
> + #:modules ((guix build gnu-build-system)
> (guix build utils)
> (srfi srfi-1)
> - (srfi srfi-26))
> - ,@(package-arguments bash))))
> + (srfi srfi-26)))))
> (substitute-keyword-arguments args
Excellent! Thank you and Rennes and Manolis for the excellent bug
sleuthing.
> I'm afraid I understood almost nothing about your comments of
> visibility. The only thing I've got is that keyword argument order
> matters :)
Sorry for the digression! I didn't help things by using the term
"keyword" in two different ways :P
> Would the similar ordering change have the no-op effect in master
> branch or does it mean core-updates should do this reordering while
> master should not?
Yes, it should have no effect. On the other hand I don't know if it
would cause a whole-world rebuild; maybe that would be a reason to not
apply it to master? I defer to Ludovic here.
Andy