[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Cache eviction policy of ‘guix publish’
From: |
Ludovic Courtès |
Subject: |
Re: Cache eviction policy of ‘guix publish’ |
Date: |
Fri, 21 Jul 2017 17:05:16 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Mark H Weaver <address@hidden> skribis:
> address@hidden (Ludovic Courtès) writes:
>
>> Mark H Weaver <address@hidden> skribis:
>>
>>> How about simply adding an option to 'guix publish' that prevents any
>>> NAR/NARINFO from being expired from the cache as long as the
>>> corresponding item is present in the store? It could be called
>>> something like --never-expire-valid-store-items.
>>>
>>> More concretely, at the point in the code where a cache item is expired
>>> in the current code, insert an additional check: if the
>>> --never-expire-valid-store-items option is enabled and the corresponding
>>> store path is still valid, then do not expire it.
>>>
>>> What do you think?
>>
>> Good idea. The patch below implements this policy. I’m tempted to just
>> make that policy the default and not even add a command-line option to
>> switch to the current policy. WDYT?
>
> Sure, sounds good to me.
Pushed as c95644f0172ba87822ee7ecee3d2743ebd2c84bc.
I’ll update ‘guix publish’ on hydra.gnu.org sometime next week if nobody
beats me at it.
Thanks!
Ludo’.