[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [WIP][PATCH] download: Don't report the progress too fast
From: |
宋文武 |
Subject: |
Re: [WIP][PATCH] download: Don't report the progress too fast |
Date: |
Wed, 20 Sep 2017 20:04:48 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> address@hidden (宋文武) skribis:
>
>> From d0c49ac1341c21d0efb069afb1521f61541e3eb4 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <address@hidden>
>> Date: Sat, 16 Sep 2017 14:10:18 -0600
>> Subject: [PATCH] download: Don't report the progress too fast.
>>
>> * guix/utils.scm (<progress-reporter>): New record type.
>> (call-with-progress-reporter): New procedure.
>> * guix/build/download.scm (dump-port*, rate-limited, progress-reporter/file):
>> New procedures.
>> (ftp-fetch, http-fetch): Use 'dump-port*'.
>> (progress-proc): Remove procedure.
>> * guix/scripts/substitute.scm (progress-report-port): Rewrite in terms of
>> <progress-reporter>.
>> (process-substitution): Adjust accordingly.
>
> LGTM. If you’ve confirmed that it works as intended, please push.
>
Done, thanks for the review!