[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: IcedTea is not linking correctly with libjvm.so
From: |
Roel Janssen |
Subject: |
Re: IcedTea is not linking correctly with libjvm.so |
Date: |
Mon, 30 Oct 2017 11:22:02 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.1.1 |
Ricardo Wurmus writes:
> Roel Janssen <address@hidden> writes:
>
>> gnu/packages/java.scm | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
>> index 95fba20e8..81cfdc132 100644
>> --- a/gnu/packages/java.scm
>> +++ b/gnu/packages/java.scm
>> @@ -1404,6 +1404,18 @@ bootstrapping purposes.")
>> (copy-recursively "openjdk.build/j2re-image" jre)
>> (copy-recursively "openjdk.build/j2sdk-image" jdk))
>> #t))
>> + ;; Some of the libraries in the lib/amd64 folder link to
>> libjvm.so. But that
>> + ;; shared object is located in the server/ folder, so it cannot
>> be found.
>> + ;; This phase creates a symbolic link in the lib/amd64 folder so
>> that the
>> + ;; other libraries can find it.
>> + ;;
>> + ;; See
>> https://lists.gnu.org/archive/html/guix-devel/2017-10/msg00169.html
>> + (add-after 'install 'install-libjvm
>> + (lambda* (#:key inputs outputs #:allow-other-keys)
>> + (let* ((lib-path (string-append (assoc-ref outputs "out")
>> "/lib/amd64")))
>> + (system* "ln" "--symbolic"
>> + (string-append lib-path "/server/libjvm.so")
>> + (string-append lib-path "/libjvm.so")))))
>
> Please use (symlink foo bar) instead of calling the “ln” tool. Also end
> the phase with #t.
>
> Other than that I think it’s fine as a workaround. Please also add a
> FIXME to the comment, so that we can revisit this later.
>
> Thanks!
I used (symlink ...), added a FIXME, rebuilt to see if it worked, and
pushed in 491dc2fb1.
Thanks!
Kind regards,
Roel Janssen