guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 01/05: gnu: guix: Provide the correct version string.


From: Mark H Weaver
Subject: Re: 01/05: gnu: guix: Provide the correct version string.
Date: Tue, 28 Nov 2017 20:34:36 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> civodul pushed a commit to branch master
> in repository guix.
>
> commit 91c619ebdfd065f0becbbcc742dc412dc41e77a1
> Author: Ludovic Courtès <address@hidden>
> Date:   Tue Nov 28 13:25:04 2017 +0100
>
>     gnu: guix: Provide the correct version string.
>     
>     Fixes <https://bugs.gnu.org/29429>.
>     Reported by Arun Isaac <address@hidden>.
>     
>     * gnu/packages/package-management.scm (guix)[arguments]: Move
>     'bootstrap' phase before 'configure'.  Create '.tarball-version' file.
> ---
>  gnu/packages/package-management.scm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/package-management.scm 
> b/gnu/packages/package-management.scm
> index 15c310d..6d18fa0 100644
> --- a/gnu/packages/package-management.scm
> +++ b/gnu/packages/package-management.scm
> @@ -136,13 +136,17 @@
>                      (ice-9 rdelim))
>  
>           #:phases (modify-phases %standard-phases
> -                    (add-after 'unpack 'bootstrap
> +                    (add-before 'configure 'bootstrap

This change works directly against my efforts to move all of these
'bootstrap' phases after 'unpack' instead of before 'configure'.  This
ordering is important because on some systems, e.g. mips64el-linux, it's
important for the 'patch-usr-bin-file' phase to fix the generated
autoconf scripts.  As I vaguely recall, on some systems, autoconf
generates calls to '/usr/bin/file' to determine the ABI of compiled
binaries.

Can we fix this issue in another way?

      Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]