Re: 01/01: gnu: mit-scheme: Update to 10.1.3.

[Mark H Weaver]

Hi Kei,

address@hidden writes:

> kkebreau pushed a commit to branch master
> in repository guix.
>
> commit d870cc5e8acfed6fee318a66c3ffc7244aa376a1
> Author: Kei Kebreau <address@hidden>
> Date:   Thu Dec 13 08:32:50 2018 -0500
>
>     gnu: mit-scheme: Update to 10.1.3.
>     
>     * gnu/packages/scheme.scm (mit-scheme): Update to 10.1.3.
>     [arguments]: Update 'unpack', 'configure-doc', and 'install-doc' phases
>     accordingly.
>     [supported-systems]: Limit to i686-linux and x86_64-linux.

[...]

> @@ -177,24 +171,21 @@
>                                  ("x86_64-linux"
>                                   (string-append version "-x86-64"))
>                                  ("i686-linux"
> -                                 (string-append version "-i386"))
> -                                (_
> -                                 (string-append "c-" version)))
> +                                 (string-append version "-i386")))
>                                ".tar.gz"))
>            (sha256
>             (match (%current-system)
>               ("x86_64-linux"
>                (base32
> -               "1skzxxhr0iq96bf0j5m7mvf3i4sppfyfa6gpqn34mwgkw1fx8274"))
> +               "03m7cc035w3avs91j2pcz9f15ssgvgp3rm045d1vbydqrkzfyw8k"))
>               ("i686-linux"
>                (base32
> -               "1fmlpnhf5a75db93phajh4ysbdgrgl72v45lk3kznriprl0a7jc6"))
> -             (_
> -              (base32
> -               "0w5ib5vsidihb4hb6fma3sp596ykr8izagm57axvgd6lqzwicsjg"))))))))
> +               "05sjyz90xxfnmi87qv8x0yx0fcallnzl1dciygdafp317pn489is"))))))))

Without the fallback cases in these 'match' forms, this package
definition raises an exception when asked to generate the derivation on
non-Intel systems.  Ludovic partly reverted your changes here:

  
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=966629a114fd90153784dfdbe5e332e0ac94f1bc

This commit also broke the 'guix' package on armhf-linux, and probably
on other non-Intel systems as well,

  https://hydra.gnu.org/build/3281991

although admittedly I found this surprising.

>      ;; Fails to build on MIPS, see <http://bugs.gnu.org/18221>.
> -    (supported-systems '("x86_64-linux" "i686-linux" "armhf-linux"))
> +    ;; Also, the portable C version of MIT/GNU Scheme did not work in time 
> for
> +    ;; release in version 10.1.
> +    (supported-systems '("x86_64-linux" "i686-linux"))

In general, please do not remove a system from 'supported-systems'
unless there is good reason to believe that it would be prohibitively
difficult to support the package on that system.  If there is merely a
bug or some minor unfinished work that prevents a package from building
on a given system, that is not sufficient grounds to remove it from
'supported-systems'.

       Thanks,
         Mark