Re: 01/02: gnu: sbcl: Enable core compression and xref for internals.

[Mark H Weaver]

Hi Pierre,

address@hidden writes:

> ambrevar pushed a commit to branch master
> in repository guix.
>
> commit 5c8b9a43819e174801597a249d4b46ab2526ca3b
> Author: Pierre Neidhardt <address@hidden>
> Date:   Sat Aug 24 18:25:53 2019 +0200
>
>     gnu: sbcl: Enable core compression and xref for internals.
>     
>     * gnu/packages/lisp.scm (sbcl): Do it.

This commit log is not up to our standards.  It should have mentioned
that 'zlib' was added to 'native-inputs', and that
"--with-sb-core-compression" and "--with-sb-xref-for-internals" were
added to the arguments to 'make.sh'.

Our high quality commit logs are one of the strong points of Guix.
Please, let's not start getting lazy about it.  In order to summarize
what was done in the above paragraph, it wasn't sufficient for me to
look at the diff.  I needed to look at the larger context.  I should not
need to take those extra steps to see what you did in this commit.
That's what the commit log are for.

What do you think?

      Regards,
        Mark


> ---
>  gnu/packages/lisp.scm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index a42369b..0c94283 100644
> --- a/gnu/packages/lisp.scm
> +++ b/gnu/packages/lisp.scm
> @@ -364,7 +364,8 @@ an interpreter, a compiler, a debugger, and much more.")
>         ("inetutils" ,inetutils)         ;for hostname(1)
>         ("ed" ,ed)
>         ("texlive" ,(texlive-union (list texlive-tex-texinfo)))
> -       ("texinfo" ,texinfo)))
> +       ("texinfo" ,texinfo)
> +       ("zlib" ,zlib)))
>      (arguments
>       `(#:modules ((guix build gnu-build-system)
>                    (guix build utils)
> @@ -422,6 +423,8 @@ an interpreter, a compiler, a debugger, and much more.")
>           ;; them in HOME, so it needs to be writeable.
>           (add-before 'build 'set-HOME
>             (lambda _ (setenv "HOME" "/tmp") #t))
> +         ;; TODO: We need to install the source as well (`src/code' 
> directory)
> +         ;; so that "go do definition" can work.
>           (replace 'build
>             (lambda* (#:key outputs #:allow-other-keys)
>               (setenv "CC" "gcc")
> @@ -431,7 +434,9 @@ an interpreter, a compiler, a debugger, and much more.")
>                                          (_
>                                           `("clisp")))
>                       (string-append "--prefix="
> -                                    (assoc-ref outputs "out")))))
> +                                    (assoc-ref outputs "out"))
> +                     "--with-sb-core-compression"
> +                     "--with-sb-xref-for-internals")))
>           (replace 'install
>             (lambda _
>               (invoke "sh" "install.sh")))