guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: How/where/when to ask for a patch review?


From: Ludovic Courtès
Subject: Re: How/where/when to ask for a patch review?
Date: Wed, 10 Jan 2024 00:33:11 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Hi again Tomas,

Tomas Volf <~@wolfsden.cz> skribis:

> What I tried so far:
>
> 1) Asking on the IRC (2x).  Once I even got a review, but from a 
> non-committer.
> 2) Sending email directly to the main author of the edited source file.  No
>    response.
>
> Technically I even mentioned it to the main author directly in person, but it
> was at a conference, so I can hardly blame them for it just slipping by. :)

Uh, I think I’m the guilty party, my sincere apologies!

I have to admit I have a hard time keeping up.  I review tons of
patches, but I also like to do stuff by myself, which means I tend to
select “easy” patches.

As a project, the ratio of available reviewer time to incoming patches
remains chronically small.  I feel like there are more people reviewing
and pushing patches these days, but there’s also more patches coming
in—a good problem to have, but certainly also a source of frustration.

The good news is that I’ve now reviewed
<https://issues.guix.gnu.org/65002> and it looks almost ready to me.  So
perhaps you’ll have to ping me or some other committer one last time,
but I encourage you to not give up, not so close to the finish line.

Cheers,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]