Re: Golang check phase skipping some tests?

[Sharlatan Hellseher]

Hi,

There are not too many Golang packages in Guix comparing to other
language spectific modules:

--8<---------------cut here---------------start------------->8---
grep -r "build-system go-build-system" gnu/packages | awk '{print $1}'
| sort | uniq -c | sort -rn
    382 gnu/packages/golang.scm:
     47 gnu/packages/golang-web.scm:
     34 gnu/packages/syncthing.scm:
     17 gnu/packages/golang-check.scm:
      9 gnu/packages/web.scm:
      8 gnu/packages/version-control.scm:
      7 gnu/packages/databases.scm:
      5 gnu/packages/ipfs.scm:
      5 gnu/packages/bioinformatics.scm:
      4 gnu/packages/virtualization.scm:
      4 gnu/packages/networking.scm:
      4 gnu/packages/mail.scm:
      4 gnu/packages/games.scm:
      4 gnu/packages/docker.scm:
      4 gnu/packages/check.scm:
      3 gnu/packages/file-systems.scm:
      3 gnu/packages/admin.scm:
      2 gnu/packages/time.scm:
      2 gnu/packages/textutils.scm:
      2 gnu/packages/terminals.scm:
      2 gnu/packages/password-utils.scm:
      2 gnu/packages/messaging.scm:
      2 gnu/packages/irc.scm:
      2 gnu/packages/geo.scm:
      2 gnu/packages/education.scm:
      2 gnu/packages/curl.scm:
      2 gnu/packages/containers.scm:
      2 gnu/packages/backup.scm:
      1 gnu/packages/xdisorg.scm:
      1 gnu/packages/web-browsers.scm:
      1 gnu/packages/weather.scm:
      1 gnu/packages/vpn.scm:
      1 gnu/packages/tls.scm:
      1 gnu/packages/terraform.scm:
      1 gnu/packages/tcl.scm:
      1 gnu/packages/task-runners.scm:
      1 gnu/packages/task-management.scm:
      1 gnu/packages/sync.scm:
      1 gnu/packages/shellutils.scm:
      1 gnu/packages/radio.scm:
      1 gnu/packages/pulseaudio.scm:
      1 gnu/packages/music.scm:
      1 gnu/packages/monitoring.scm:
      1 gnu/packages/linux.scm:
      1 gnu/packages/image-viewers.scm:
      1 gnu/packages/hyperledger.scm:
      1 gnu/packages/high-availability.scm:
      1 gnu/packages/finance.scm:
      1 gnu/packages/disk.scm:
      1 gnu/packages/debug.scm:
      1 gnu/packages/crypto.scm:
      1 gnu/packages/configuration-management.scm:
      1 gnu/packages/compression.scm:
      1 gnu/packages/calendar.scm:
      1 gnu/packages/authentication.scm:
      1 gnu/packages/android.scm:
--8<---------------cut here---------------start------------->8---

We may enable it globally and rebuild each package and pack and place missing in
native inputs/propagated inputs depending on the purpose.

I would love to investigate the count of packages in  `34
gnu/packages/syncthing.scm:` :-)

Thanks,
Oleg

On Thu, 18 Jan 2024 at 21:31, Troy Figiel <troy@troyfigiel.com> wrote:
>
> Hi Oleg and others,
>
> On 2024-01-18 11:25, Sharlatan Hellseher wrote:
> > With small adjustment of the invok line, I could manage to trigger all 
> > tests to
> > be run, but it brings other issue of some not packed modules required for 
> > the
> > check phase.
>
> Thanks for the update! I noticed the same with `go-github-com-kr-text'.
> It was actually missing a propagated-input that has not been packaged
> yet, so I couldn't easily fix it.
>
> On 2024-01-18 11:25, Sharlatan Hellseher wrote:
> > As a quick ad-hoc to run all tests for some new package you may add a custom
> > check phase with the snippet you provided.
> >
> > I'm currently in review and split some packages from (gnu packages golang) 
> > into
> > (gnu packages golang-crypto) to simplify the maintenance. I try to play with
> > that option and see which packages are missed to satisfy passing all tests.
>
> Once the migration is over, what would you recommend for new packages? I
> could see two options here:
>
> 1. Change the default check phase and only replace it back to the
> previous one for packages that fail to build or
>
> 2. Replace the check phase for all packages one-by-one.
>
> I noticed this behaviour when I was packaging gotenberg and as with any
> reasonably sized Golang package, this one also has a gazillion
> dependencies... I would love to start on the right track :-)
>
> Best wishes,
>
> Troy



-- 
VCS: https://github.incerto.xyz/; https://git.sr.ht/~hellseher/
GPG: 9847 81DE 689C 21C2 6418 0867 76D7 27BF F62C D2B5

… наш разум - превосходная объяснительная машина которая способна
найти смысл почти в чем угодно, истолковать любой феномен, но
совершенно не в состоянии принять мысль о непредсказуемости.