[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#33079] [PATCH 01/34] gnu: ocaml: Update to 4.07.0.
From: |
Ludovic Courtès |
Subject: |
[bug#33079] [PATCH 01/34] gnu: ocaml: Update to 4.07.0. |
Date: |
Tue, 23 Oct 2018 23:11:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello!
Julien Lepiller <address@hidden> skribis:
> * gnu/packages/ocaml.scm (ocaml): Update to 4.07.0.
> (ocaml-4.02): New variable.
[...]
> -(define-public ocaml
> +(define-public ocaml-4.02
[...]
> +(define-public ocaml ocaml-4.07)
The patch LGTM. However, in general I think we should arrange for
patches to be self-contained, such that packages build at any point in
the commit history. If we do it this way (first upgrade ocaml, then
adjust packages that depend on it), we leave whole commit ranges where
packages fail to build.
Thus I would suggest squashing into one commit the ocaml upgrade and the
package adjustments that ensue (typically the “Fix …” commits.) WDYT?
Also, do you think OCaml users typically need the “ocaml4.02-” packages?
I had a quick look at the other patches and they look innocuous, “unless
otherwise stated.” ;-)
Thank you!
Ludo’.
- [bug#33079] [PATCH 33/34] gnu: Fix ocaml-rresult., (continued)
- [bug#33079] [PATCH 33/34] gnu: Fix ocaml-rresult., Julien Lepiller, 2018/10/17
- [bug#33079] [PATCH 29/34] gnu: Add ocaml-ppx-tools-versioned., Julien Lepiller, 2018/10/17
- [bug#33079] [PATCH 32/34] gnu: Fix ocaml-topkg., Julien Lepiller, 2018/10/17
- [bug#33079] [PATCH 21/34] gnu: Fix ocaml-frontc., Julien Lepiller, 2018/10/17
- [bug#33079] [PATCH 16/34] gnu: unison: Build with ocaml-4.02., Julien Lepiller, 2018/10/17
- [bug#33079] [PATCH 18/34] gnu: Add ocaml4.02-camlzip., Julien Lepiller, 2018/10/17
- [bug#33079] [PATCH 24/34] gnu: Fix ocaml-stringext., Julien Lepiller, 2018/10/17
- [bug#33079] [PATCH 27/34] gnu: Add dune., Julien Lepiller, 2018/10/17
- [bug#33079] [PATCH 34/34] gnu: Update ocaml packages., Julien Lepiller, 2018/10/17
- [bug#33079] [PATCH 01/34] gnu: ocaml: Update to 4.07.0.,
Ludovic Courtès <=