[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#35935] [PATCH] guix: import: simplify recursive import
From: |
Oleg Pykhalov |
Subject: |
[bug#35935] [PATCH] guix: import: simplify recursive import |
Date: |
Mon, 03 Jun 2019 22:56:21 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Hello Robert,
Robert Vollmert <address@hidden> writes:
[…]
>> I think Oleg worked on this part before; Oleg, could you comment
>> and/or apply?
>>
>> ‘tests/import-utils.scm’ doesn’t seem to be testing this procedure,
>> perhaps that’s something we should fix eventually.
>
> Agreed. It does seem to be covered somewhat by tests/gem.scm.
> I also tested it a bit by hand, with some haskell packages.
True, ‘tests/gem.scm’ file tests ‘recursive-import’ procedure by
invoking ‘gem-recursive-import’. I think this test is good enough for
our purpose - use ‘recursive-import’ in other package importers and make
sure it works. Thoughts?
I also added a copyright line if you don't mind:
;;; Copyright © 2019 Robert Vollmert <address@hidden>
Is it OK, Robert? I tested manually with ‘gem’ and ‘elpa’ recursive
importers and ready to push :-)
Thanks,
Oleg.
signature.asc
Description: PGP signature